[PATCH] D93712: [flang][driver] Add checks for errors from `Prescan` and `Parse`

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

In D93712#2481647 <https://reviews.llvm.org/D93712#2481647>, @sscalpone wrote:

> I can see how these messages can be useful for a compiler developer; however, perhaps these messages are redundant for end users because other error messages have been issued.

Thank you for the suggestion! I actually pushed this change pretty much at the point when you were sending this. Obviously we can refine this.

For now I'd like to prioritise consistency with `f18`. Once `flang-new` is ready to replace `f18`, we could focus on refining the user experience.  Also, when end-users report erros to developers, it's good to have a message that allows developers narrow the error down. So I still think that it's worthwhile to have specialized  error messages (e.g. `could not parse` vs `could not scan`) in the driver. Lastly, wouldn't the frontend driver be considered more of a _developer_  rather than _end-user_ tool?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93712/new/

https://reviews.llvm.org/D93712