[PATCH] D93712: [flang][driver] Add checks for errors from `Prescan` and `Parse`

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Thanks @sameeranjoshi !



================
Comment at: flang/lib/Frontend/FrontendAction.cpp:60
+    unsigned diagID = ci.diagnostics().getCustomDiagID(
+        clang::DiagnosticsEngine::Error, "could not scan %0");
+    ci.diagnostics().Report(diagID) << GetCurrentFileOrBufferName();
----------------
sameeranjoshi wrote:
> `nit:` - Should the error messages start with a capital letter?
> https://github.com/llvm/llvm-project/blob/master/flang/docs/C++style.md#error-messages
Good point. The current implementation is consistent with `f18`: https://github.com/llvm/llvm-project/blob/main/flang/tools/f18/f18.cpp#L212 and that's what I've been prioritizing. I'm not sure whether `f18` is intentionally inconsistent with the coding guidelines or not.

I suggest that these messages are updated in a separate patch for both `f18` and `flang-new`. Since it's an NFC, I pushed it without a separate review (https://github.com/llvm/llvm-project/commit/fa1e543e0b8c625bf2625598d9a16c484e349884). Thanks for pointing this out!




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93712/new/

https://reviews.llvm.org/D93712