[PATCH] D93811: [VE] Support llvm.eh.sjlj.lsda

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 4 01:33:34 PST 2021


kaz7 added inline comments.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1550
+    const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+    MVT PtrVT = TLI.getPointerTy(DAG.getDataLayout());
+    const VETargetMachine *TM =
----------------
simoll wrote:
> I suppose you could re-use the type of `Op` here
I'm not sure about it.  Do you have any strategies to decide either Op.getValueType() or TLI.getPointerTy()?  All other architectures use TLI.getPointerTy() to implement lsda.  It's really difficult to decide it with certain reasons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93811/new/

https://reviews.llvm.org/D93811



More information about the llvm-commits mailing list