[PATCH] D93811: [VE] Support llvm.eh.sjlj.lsda

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1550
+    const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+    MVT PtrVT = TLI.getPointerTy(DAG.getDataLayout());
+    const VETargetMachine *TM =
----------------
I suppose you could re-use the type of `Op` here


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1554
+
+    // Creat GCC_except_tableXX string.  The real symbol for that will be
+    // generated in EHStreamer::emitExceptionTable() later.  So, we just
----------------
typo Creat


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1566
+      return DAG.getNode(ISD::ADD, DL, PtrVT, GlobalBase, Addr);
+    } else {
+      return makeHiLoPair(Addr, VEMCExpr::VK_VE_HI32, VEMCExpr::VK_VE_LO32,
----------------
style: else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93811/new/

https://reviews.llvm.org/D93811