[PATCH] D93804: [RISCV] Spilling for RISC-V V extension.

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:97
+  // enabled. See llvm/test/CodeGen/RISCV/rvv/spill-vector-csr.ll.
+  if (TFI->hasFP(MF) || Subtarget.hasStdExtV())
     markSuperRegs(Reserved, RISCV::X8); // fp
----------------
frasercrmck wrote:
> Should `hasFP` not pessimistically return true if V is enabled?
Do you mean to move Subtarget.hasStdExtV() into hasFP()? To consider spilling, it seems reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93804/new/

https://reviews.llvm.org/D93804