[PATCH] D87145: [SelectionDAG] Remove an early-out from computeKnownBits for smin/smax

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added reviewers: pengfei, yubing.
RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/avx512-trunc.ll:1020
 ; SKX-NEXT:    vzeroupper
 ; SKX-NEXT:    retq
   %x1 = icmp sgt <16 x i16> %i, <i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0, i16 0>
----------------
RKSimon wrote:
> craig.topper wrote:
> > RKSimon wrote:
> > > Is this testing what it means to? I can't remember offhand what the test is for - @craig.topper any ideas?
> > Not sure either.  InstCombine simplifies it to a store of all ones.
> The test was added as part of D45315 - @ArturGainullin hasn't been an active for some time afaict.
> 
> I think we might be able to get away with adjusting the -1 splat to be a non-uniform mix of -ve constant values.
Any recommendations on what to do with these tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87145/new/

https://reviews.llvm.org/D87145