[PATCH] D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values

[Congzhe Cao via Phabricator via llvm-commits]

congzhe added a comment.

In D93065#2475022 <https://reviews.llvm.org/D93065#2475022>, @aqjune wrote:

> Okay, I think the remaining optimizations (other than opened patches) are:
>
> - LoopUnswitch.cpp: I can address this
> - PredicateInfo.cpp: I'm not sure whether a local change will be enough, because the relevant classes in PredicateInfo.h are exposed to other optimizations.
> - SimpleLoopUnswitch.cpp, LoopPredication.cpp, InductiveRangeCheckElimination.cpp: have no idea
>
> After LoopUnswitch and PredicateInfo is updated & the select -> and/or is conditionally allowed, we can try performance evaluation again and see whether there still exists regression. What do you think? @nikic @congzhe

Thank you all for putting all the efforts addressing the canonicalization of select form! 
Sure I will apply all these patches, check the benchmark performance and let you know the result. Thanks again!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93065/new/

https://reviews.llvm.org/D93065