[PATCH] D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values
Juneyoung Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 30 05:25:55 PST 2020
aqjune added a comment.
Okay, I think the remaining optimizations (other than opened patches) are:
- LoopUnswitch.cpp: I can address this
- PredicateInfo.cpp: I'm not sure whether a local change will be enough, because the relevant classes in PredicateInfo.h are exposed to other optimizations.
- SimpleLoopUnswitch.cpp, LoopPredication.cpp, InductiveRangeCheckElimination.cpp: have no idea
After LoopUnswitch and PredicateInfo is updated & the select -> and/or is conditionally allowed, we can try performance evaluation again and see whether there still exists regression. What do you think? @nikic @congzhe
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93065/new/
https://reviews.llvm.org/D93065
More information about the llvm-commits
mailing list