[PATCH] D93859: [GlobalISel][TableGen] Add BitsPerByte value

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3816
       unsigned MemSizeInBits =
-          llvm::alignTo(MemTyOrNone->get().getSizeInBits(), 8);
+          llvm::alignTo(MemTyOrNone->get().getSizeInBits(),
+                        Target.getBitsPerByte());
----------------
Could you fix the English in the comment above?

I should know, but which getSizeInBits() is this calling? There are two definitions, both with the 8 hardwired. One is in CodeGen/MachineMemOperand.h and the other in ir/DataLayout.h.

Ah, is it calling the one in LowLevelTypeImpl.h? That one doesn't have a hardwired 8, although the function getSizeInBytes does.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93859/new/

https://reviews.llvm.org/D93859