[PATCH] D93849: [RISCV] Define vmclr.m/vmset.m intrinsics.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:65
+                         MachineBasicBlock::iterator MBBI,
+                         bool IsVMCLR = false);
 };
----------------
Drop the default and just pass value at both call sites. There's no strong reason for vmset to the be the default behavior so its better to make it explicit.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:559
+  let SEWIndex = 2;
+  // set base instr as pseduo instruction which would expand later.
+  let BaseInstr = !cast<Instruction>("Pseudo" # PseudoToVInst<NAME>.VInst);
----------------
pseduo -> pseudo


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vmclr-rv32.ll:2
+; RUN: llc -mtriple=riscv32 -mattr=+experimental-v,+f,+experimental-zfh -verify-machineinstrs \
+; RUN:   --riscv-no-aliases < %s | FileCheck %s
+declare <vscale x 1 x i1> @llvm.riscv.vmclr.nxv1i1(
----------------
Can we drop -riscv-no-aliases so that we'll print vmset/vmclr?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93849/new/

https://reviews.llvm.org/D93849