[PATCH] D93750: [RISCV] Frame handling for RISC-V V extension.

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 24 19:21:29 PST 2020


StephenFan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:829
+      // true.
+      MFI.setStackID(FI, TargetStackID::RISCVVector);
+    }
----------------
Is This for loop unuseful? because in the FunctionLoweringinfo.cpp has a set function that will setstackid
```
          if (isa<ScalableVectorType>(Ty))
            MF->getFrameInfo().setStackID(FrameIndex,
                                          TFI->getStackIDForScalableVectors());
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93750/new/

https://reviews.llvm.org/D93750



More information about the llvm-commits mailing list