[PATCH] D91435: [AMDGPU] Split edge to make si_if dominate end_cf

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 24 00:08:55 PST 2020


alex-t added a comment.

In D91435#2470128 <https://reviews.llvm.org/D91435#2470128>, @arsenm wrote:

> There should be both tests, not one larger function that hits both

This second pattern requires the first one to manifest. So even if I split the tests, the second will contain both patterns.
Does it make sense?
I checked the behavior of the united test commenting out the first fix and the second one - both changes were separately controlled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91435/new/

https://reviews.llvm.org/D91435



More information about the llvm-commits mailing list