[PATCH] D93750: [RISCV] Frame handling for RISC-V V extension.

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 23 19:54:52 PST 2020


HsiangKai added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:280
+  // We do not want the generic alignment handling in
+  // PEI::calculateFrameObjectOffsets(). We store the pointers of RVV objects
+  // in the frame, instead of storing RVV objects themselves. That is why we
----------------
jrtc27 wrote:
> Hm, looking at the stack-realignment.ll diff, were we double-counting before? If so it'd be worth splitting out that bit of this revision into its own smaller one.
I think so. I will create another patch for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93750/new/

https://reviews.llvm.org/D93750



More information about the llvm-commits mailing list