[PATCH] D93670: [AMDGPU][GlobalISel] GlobalISel for flat scratch

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3644-3645
+
+  if (!isSGPR(SAddr))
+    return None;
+
----------------
rampitec wrote:
> arsenm wrote:
> > Should hoist this up?
> The block above processes G_PTR_ADD and reassigns SAddrs. G_PTR_ADD produces VGPR but resulting register can end up SGPR.
But the reassignment just creates an SGPR virt reg


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93670/new/

https://reviews.llvm.org/D93670