[PATCH] D93670: [AMDGPU][GlobalISel] GlobalISel for flat scratch

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 22 10:29:59 PST 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3644-3645
+
+  if (!isSGPR(SAddr))
+    return None;
+
----------------
arsenm wrote:
> Should hoist this up?
The block above processes G_PTR_ADD and reassigns SAddrs. G_PTR_ADD produces VGPR but resulting register can end up SGPR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93670/new/

https://reviews.llvm.org/D93670



More information about the llvm-commits mailing list