[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef
Paul C. Anagnostopoulos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 22 10:05:49 PST 2020
Paul-C-Anagnostopoulos marked an inline comment as done.
Paul-C-Anagnostopoulos added a comment.
The modification occurs on line 65:
llvm::erase_if(defs, ...
My temptation would be to add a macro to make it clear what's going on:
MODIFY_DEF_VECTOR std::vector<llvm::Record *> defs =
recordKeeper.getAllDerivedDefinitions("OpInterface");
But I haven't seen that sort of thing done in LLVM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93654/new/
https://reviews.llvm.org/D93654
More information about the llvm-commits
mailing list