[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return an ArrayRef

[Chris Lattner via Phabricator via llvm-commits]

lattner added a comment.

this looks great to me Paul.  I don't see the client that modifies the array, but such a client can do an explicit copy into its own std::vector



================
Comment at: llvm/utils/TableGen/CodeEmitterGen.cpp:464
   // Construct all cases statement for each opcode
-  for (std::vector<Record*>::iterator IC = Insts.begin(), EC = Insts.end();
+  for (ArrayRef<Record *>::const_iterator IC = Insts.begin(), EC = Insts.end();
         IC != EC; ++IC) {
----------------
I'd personally use 'auto' for this iterator type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654