[PATCH] D93660: [WebAssembly][NFC] Refactor SIMD load/store tablegen defs

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 19:04:02 PST 2020


aheejin added a comment.

Wow, I didn't know we can do OOP in TableGen! (Are these new functionalities?)



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:57-58
+  let lane_idx = LaneIdx16;
+  let prefix = "i8x16";
+  let vprefix = "v8x16";
+}
----------------
Do we need to separately maintain 4 different fields with the same info:
`I8x16` (in def), `vt` (`v16i8`), `prefix` (`i8x16`), and `vprefix` (`v8x16`)
Maybe it can be hard to unify all of these, but can we merge some?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93660/new/

https://reviews.llvm.org/D93660



More information about the llvm-commits mailing list