[PATCH] D93612: [RISCV] Update V instructions constraints to conform to v1.0

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.h:96
   WidenCvt = VS2Constraint | VMConstraint | OneInput,
-  Narrow = VS2Constraint | VMConstraint,
-  NarrowCvt = VS2Constraint | VMConstraint | OneInput,
-  Vmadc = VS2Constraint | VS1Constraint,
+  Narrow = VMConstraint,
+  NarrowCvt = VMConstraint | OneInput,
----------------
Were we missing test coverage for the constraint removed here?


================
Comment at: llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.h:99
   Iota = VS2Constraint | VMConstraint | OneInput,
-  SlideUp = VS2Constraint | VMConstraint,
-  Vrgather = VS2Constraint | VS1Constraint | VMConstraint,
+  SlideUp = VS2Constraint,
+  Vrgather = VS2Constraint | VS1Constraint,
----------------
Same here?


================
Comment at: llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.h:99
   Iota = VS2Constraint | VMConstraint | OneInput,
-  SlideUp = VS2Constraint | VMConstraint,
-  Vrgather = VS2Constraint | VS1Constraint | VMConstraint,
+  SlideUp = VS2Constraint,
+  Vrgather = VS2Constraint | VS1Constraint,
----------------
craig.topper wrote:
> Same here?
Why wouldn't VMConstraint apply to SlideUp and Vrgather? I thought that was a general rule.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93612/new/

https://reviews.llvm.org/D93612