[PATCH] D93534: [VP] Improve the VP intrinsic unittests

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 added a comment.

This is what I feel when I see this test.  Just a thought.  Not a requirement.  But, I think it's possible to improve this test in that way.



================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:67
+  ScopeOPC = None;
+#include "llvm/IR/VPIntrinsics.def"
+
----------------
1. In this unittest, test cases are generated by either from a result of `CreateVPDeclarationModule` call or through macros in `llvm/IR/VPIntrinsics.def`.  Isn't it possible to use one consistent way?
2. Generating unit tests directly through macros in `llvm/IR/VPIntrinsics.def` requires some techniques, but it makes review difficult.  For example, isn't it possible to generate a table first using macros, then test values in the table in unit tests, to make test system simple?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93534/new/

https://reviews.llvm.org/D93534