[PATCH] D93534: [VP] Improve the VP intrinsic unittests

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:210
+    auto VPID = VPDecl.getIntrinsicID();
+    unsigned OPC = VPIntrinsic::GetFunctionalOpcodeForVP(VPID);
+
----------------
Nit but `OPC` seems inconsistent with `OC` above. In general, the all-caps variable names looks a bit out of place to me. I'd suggest `Opc`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93534/new/

https://reviews.llvm.org/D93534