[PATCH] D93433: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes.

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/include/llvm/IR/ValueHandle.h:447
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
     final : public CallbackVH
 #endif
----------------
dblaikie wrote:
> Would it be OK (follow-up/preliminary commit) to move `final` out of this block? So the type is always final - or does that break something else?
Interesting; I hadn't considered putting `final` on a class that doesn't inherit from anything, but I imagine you're right and this could be moved out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93433/new/

https://reviews.llvm.org/D93433