[PATCH] D93433: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me - couple of side comments, possibly more directed at other reviewers to discuss/consider.



================
Comment at: llvm/include/llvm/IR/ValueHandle.h:290
   AssertingVH(ValueTy *P) : ThePtr(GetAsValue(P)) {}
   AssertingVH(const AssertingVH<ValueTy> &) = default;
 #endif
----------------
Follow-up/preliminary commit could probably remove the `<ValueTy>` from this line, I think.


================
Comment at: llvm/include/llvm/IR/ValueHandle.h:447
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
     final : public CallbackVH
 #endif
----------------
Would it be OK (follow-up/preliminary commit) to move `final` out of this block? So the type is always final - or does that break something else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93433/new/

https://reviews.llvm.org/D93433