[PATCH] D93561: [X86] Avoid generating invalid R_X86_64_GOTPCRELX relocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 13:12:27 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/MC/X86/gotpcrelx.s:91
 ## We could emit R_X86_64_GOTPCRELX, but it is probably unnecessary.
 movl mov at GOTPCREL+0(%rip), %eax
----------------
LG.

May I bother you to delete ELF/got-relaxed-rex.s and add its test coverage into this file as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93561/new/

https://reviews.llvm.org/D93561



More information about the llvm-commits mailing list