[PATCH] D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive

Lucas Prates via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 06:02:10 PST 2020


pratlucas marked an inline comment as done.
pratlucas added inline comments.


================
Comment at: llvm/test/MC/AArch64/directive-arch_extension-negative.s:87
+
+.arch_extension nols64
+ld64b x0, [x13]
----------------
ostannard wrote:
> This feature isn't enabled by default, so I'd expect this test to still pass even if the `.arch_extension nols64` line was removed. We should enable all of these extensions with command-line options to llvm-mc, and probably add checks that the instructions are accepted before the extension is disabled.
> 
> This is an existing problem with many of the other tests in this file, so doing this as a separate patch would be best.
I've updated the test on D93538.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92574/new/

https://reviews.llvm.org/D92574



More information about the llvm-commits mailing list