[PATCH] D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 01:42:47 PST 2020


ostannard added inline comments.


================
Comment at: llvm/test/MC/AArch64/directive-arch_extension-negative.s:87
+
+.arch_extension nols64
+ld64b x0, [x13]
----------------
This feature isn't enabled by default, so I'd expect this test to still pass even if the `.arch_extension nols64` line was removed. We should enable all of these extensions with command-line options to llvm-mc, and probably add checks that the instructions are accepted before the extension is disabled.

This is an existing problem with many of the other tests in this file, so doing this as a separate patch would be best.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92574/new/

https://reviews.llvm.org/D92574



More information about the llvm-commits mailing list