[PATCH] D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector.

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:784
+  Optional<unsigned> MaxNumVScale = getMaxVScale();
+  // TODO: Replace assert for InstructionCost
+  assert(MaxNumVScale && "Expected valid max vscale value");
----------------
david-arm wrote:
> nit: Sorry I didn't spot this before. Does the TODO still make sense here?
Yes, because I cannot replace this to return InstructionCost without changing a big chain of functions to InstructionCost.
I believe we will tackle this problem later, in another patch responsible to replace these functions to return InstructionCost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93030/new/

https://reviews.llvm.org/D93030