[PATCH] D93030: [AArch64][SVE]Add cost model for masked gather and scatter for scalable vector.

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! Hi @tschuett I agree I think it's better to leave any possible refinement of getMaxVScale to a later patch as it may require new flags.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:784
+  Optional<unsigned> MaxNumVScale = getMaxVScale();
+  // TODO: Replace assert for InstructionCost
+  assert(MaxNumVScale && "Expected valid max vscale value");
----------------
nit: Sorry I didn't spot this before. Does the TODO still make sense here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93030/new/

https://reviews.llvm.org/D93030