[PATCH] D93400: [IRBuilder] Generalize debug loc handling for arbitrary metadata.

Thu Dec 17 15:06:40 PST 2020

fhahn added a comment.

In D93400#2461288 <https://reviews.llvm.org/D93400#2461288>, @nikic wrote:

> FYI this has a noticeable compile-time impact: http://llvm-compile-time-tracker.com/compare.php?from=deae7e982a3b08996455e2cdfdc5062bf37895a3&to=01089c876bff43a7cde1cb9b1ef8c128169ec5b4&stat=instructions (including the change that adjusts InstCombine)
>
> Something to keep in mind is that debug metadata is privileged, and a reference to it is stored in the instruction. Fetching the annotation metadata (even if it does not exist, but *some* kind of metadata exists) requires looking up the instruction in the metadata map and scanning the metadata vector.

Thanks for the heads up. This is definitely something that needs to be addressed. I'll try a few things tomorrow. Surprising to see there's actually a speedup with the `ReleaseLTO + g`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93400/new/

https://reviews.llvm.org/D93400