[PATCH] D93400: [IRBuilder] Generalize debug loc handling for arbitrary metadata.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

FYI this has a noticeable compile-time impact: http://llvm-compile-time-tracker.com/compare.php?from=deae7e982a3b08996455e2cdfdc5062bf37895a3&to=01089c876bff43a7cde1cb9b1ef8c128169ec5b4&stat=instructions (including the change that adjusts InstCombine)

Something to keep in mind is that debug metadata is privileged, and a reference to it is stored in the instruction. Fetching the annotation metadata (even if it does not exist, but *some* kind of metadata exists) requires looking up the instruction in the metadata map and scanning the metadata vector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93400/new/

https://reviews.llvm.org/D93400