[PATCH] D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCCTRLoops.cpp:11
+// mtctr before any other instructions that might clobber the ctr register.
 //
 //===----------------------------------------------------------------------===//
----------------
Complete passes that are only defined for non-NDEBUG builds are rare and I think a comment should explain what is going on here. Something like:

CTR loops are produced by the HardwareLoops pass and this pass is simply a verification that no invalid CTR loops are produced. As such, it isn't something that needs to be run (or even defined) for Release builds so the entire file is guarded by NDEBUG.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93336/new/

https://reviews.llvm.org/D93336