[PATCH] D93336: [PowerPC][NFC] Cleanup PPCCTRLoopsVerify pass

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCCTRLoops.cpp:16
+
+#include "MCTargetDesc/PPCMCTargetDesc.h"
 #include "PPC.h"
----------------
shchenz wrote:
> Seems now we only need following headers:
> ```
> #include "MCTargetDesc/PPCMCTargetDesc.h"
> #include "PPC.h"
> #include "llvm/ADT/SmallSet.h"
> #include "llvm/ADT/SmallVector.h"
> #include "llvm/CodeGen/MachineBasicBlock.h"
> #include "llvm/InitializePasses.h"
> #include "llvm/Pass.h"
> #include "llvm/Support/Debug.h"
> #include "llvm/CodeGen/MachineDominators.h"
> #include "llvm/CodeGen/MachineFunction.h"
> #include "llvm/CodeGen/MachineFunctionPass.h"
> ```
```
The full include-list for /home/jji/llvm-project/llvm/lib/Target/PowerPC/PPCCTRLoops.cpp:
#include <vector>                                     // for vector
#include "MCTargetDesc/PPCMCTargetDesc.h"             // for CTR, CTR8, BDNZ
#include "PPC.h"                                      // for createPPCCTRLoo...
#include "llvm/ADT/SmallSet.h"                        // for SmallSet
#include "llvm/ADT/SmallVector.h"                     // for SmallVector
#include "llvm/ADT/StringRef.h"                       // for StringRef
#include "llvm/ADT/ilist_iterator.h"                  // for operator!=, ope...
#include "llvm/CodeGen/MachineBasicBlock.h"           // for MachineBasicBlock
#include "llvm/CodeGen/MachineDominators.h"           // for MachineDominato...
#include "llvm/CodeGen/MachineFunction.h"             // for MachineFunction
#include "llvm/CodeGen/MachineFunctionPass.h"         // for MachineFunction...
#include "llvm/CodeGen/MachineInstr.h"                // for operator<<, Mac...
#include "llvm/CodeGen/MachineInstrBundleIterator.h"  // for MachineInstrBun...
#include "llvm/CodeGen/MachineOperand.h"              // for MachineOperand
#include "llvm/CodeGen/Register.h"                    // for Register
#include "llvm/InitializePasses.h"                    // for initializeMachi...
#include "llvm/Pass.h"                                // for AnalysisUsage
#include "llvm/PassRegistry.h"                        // for PassRegistry
#include "llvm/Support/CodeGen.h"                     // for llvm
#include "llvm/Support/Debug.h"  // lines 40-40
#include "llvm/Support/ErrorHandling.h"               // for llvm_unreachable
#include "llvm/Support/GenericDomTreeConstruction.h"  // for dbgs, LLVM_DEBUG
#include "llvm/Support/Printable.h"                   // for operator<<, Pri...
#include "llvm/Support/raw_ostream.h"                 // for raw_ostream
---
```
This is the output of include what you use, some of the include may have been included in some other headers, I would prefer we keep this as we may want to reduce some include in headers as well later.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93336/new/

https://reviews.llvm.org/D93336