[PATCH] D93413: [NFC] factor update test function test builder as a class

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked 4 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:351
+
+  def close(self):
+    warn_on_failed_prefixes(self._func_dict)
----------------
pengfei wrote:
> When is `close` called?
never - thanks for the catch


================
Comment at: llvm/utils/update_cc_test_checks.py:255
+        all_prefixes.add(prefix)
+    builder = common.FunctionTestBuilder(
+      prefixes=all_prefixes,
----------------
pengfei wrote:
> I think we just need to pass ti.args here. Together with above, it can be simplied to
> ```
> builder = common.FunctionTestBuilder(run_list, ti.args)
> ```
that almost worked seamlessly, llc_tests had a different args object, but easy fix. Less unpacking/repacking parameters overall.


================
Comment at: llvm/utils/update_llc_test_checks.py:129
+      scrubber, function_re = asm.get_run_handler(triple)
+      builder.process_run_line(function_re, scrubber, [ti.args],
+                               raw_tool_output, prefixes)
----------------
pengfei wrote:
> This argument duplicated with class members.
not in all cases though. in fact, all but update_llc_test_checks have it []. I'll pass it in the ctor though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93413/new/

https://reviews.llvm.org/D93413