[PATCH] D93413: [NFC] factor update test function test builder as a class

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:351
+
+  def close(self):
+    warn_on_failed_prefixes(self._func_dict)
----------------
When is `close` called?


================
Comment at: llvm/utils/update_cc_test_checks.py:251-254
     for p in run_list:
       prefixes = p[0]
       for prefix in prefixes:
+        all_prefixes.add(prefix)
----------------
I think we can put this code into the class initialization.


================
Comment at: llvm/utils/update_cc_test_checks.py:255
+        all_prefixes.add(prefix)
+    builder = common.FunctionTestBuilder(
+      prefixes=all_prefixes,
----------------
I think we just need to pass ti.args here. Together with above, it can be simplied to
```
builder = common.FunctionTestBuilder(run_list, ti.args)
```


================
Comment at: llvm/utils/update_llc_test_checks.py:129
+      scrubber, function_re = asm.get_run_handler(triple)
+      builder.process_run_line(function_re, scrubber, [ti.args],
+                               raw_tool_output, prefixes)
----------------
This argument duplicated with class members.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93413/new/

https://reviews.llvm.org/D93413