[PATCH] D93263: [lld-macho] Implement option: -undefined TREATMENT
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 16 11:47:28 PST 2020
smeenai added inline comments.
================
Comment at: lld/MachO/SymbolTable.cpp:147
+ StringRef fileName) {
+ Twine message = (fileName.size() ? "undefined symbol: " + symbolName +
+ "\n>>> referenced by " + fileName
----------------
Nit: using `empty` for this purpose is more idiomatic than `size`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93263/new/
https://reviews.llvm.org/D93263
More information about the llvm-commits
mailing list