[PATCH] D93263: [lld-macho] Implement option: -undefined TREATMENT

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/invalid/stub-link.s:11
 
-# CHECK-DAG: error: undefined symbol __cache_handle_memory_pressure_event
-# CHECK-DAG: error: undefined symbol _from_non_reexported_tapi_dylib
+# CHECK-DAG: error: undefined symbol '__cache_handle_memory_pressure_event'
+# CHECK-DAG: error: undefined symbol '_from_non_reexported_tapi_dylib'
----------------
this string should probably be changed too?


================
Comment at: lld/test/MachO/treat-undef-sym.s:14
+# ERROR: error: undefined symbol: _bar
+# ERROR-NEXT: >>> referenced by
+
----------------
one final nit: why not include the filename here too? Or, if we're just interested in checking for error vs warning, then we could just leave out the check for the "referenced by" line. Checking that those two words exist in isolation doesn't seem super useful...

(thanks for changing the format string btw)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93263/new/

https://reviews.llvm.org/D93263