[PATCH] D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/aarch64-variant_pcs.s:59
+
+//--- test1
+## An object with a variant_pcs symbol but without a R_AARCH64_JMP_SLOT
----------------
zatrazz wrote:
> MaskRay wrote:
> > `#---`
> > 
> > Just use the same comment marker as other comments
> Ack.
> 
> Should I resend a newer version?
Yes.

Unlikely email based reviews (where I might feel bad once my patch reached v5, v6, ...), there is nothing bad uploading several versions on Phabricator. Reviewers and CCers will get an email but that happens for each comment as well, so they should have high tolerance...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93045/new/

https://reviews.llvm.org/D93045