[PATCH] D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz added inline comments.


================
Comment at: lld/test/ELF/aarch64-variant_pcs.s:5
+# RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %t/test1 -o %t.o
+# RUN: ld.lld %t.o --shared --soname=%t.so -o %t.so
+# RUN: llvm-readelf --dynamic-table %t.so | FileCheck --check-prefix T1-PCSDYN %s
----------------
MaskRay wrote:
> Delete `--soname=%t.so` (you encode the absolute path %t into DT_SONAME)
> 
> If a shared object is not used for linking in the same test, it does not need DT_SONAME.
Ack.


================
Comment at: lld/test/ELF/aarch64-variant_pcs.s:59
+
+//--- test1
+## An object with a variant_pcs symbol but without a R_AARCH64_JMP_SLOT
----------------
MaskRay wrote:
> `#---`
> 
> Just use the same comment marker as other comments
Ack.

Should I resend a newer version?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93045/new/

https://reviews.llvm.org/D93045