[PATCH] D93132: [SVE][CodeGen] Vector + immediate addressing mode for masked gather/scatter

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 09:06:50 PST 2020


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3928
+
+  unsigned OffsetVal = Offset->getZExtValue();
+  unsigned ScalarSizeInBytes = MemVT.getScalarSizeInBits() / 8;
----------------
nit: I very much doubt it makes any practical difference, but perhaps it's best to use uint64_t instead of unsigned here, since that's what getZExtValue() returns and this is used to create the i64 constant below?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93132/new/

https://reviews.llvm.org/D93132



More information about the llvm-commits mailing list