[PATCH] D93394: CodeGen: Move function to get subregister indexes to cover a LaneMask

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D93394#2458010 <https://reviews.llvm.org/D93394#2458010>, @arsenm wrote:

> In D93394#2457781 <https://reviews.llvm.org/D93394#2457781>, @foad wrote:
>
>> Seems like an obvious refactoring to me. I think the API could be simplified though. How about returning all indices via the SmallVector, and returning a bool failure indication? Or say that if the vector is empty, it means failure?
>
> I was conflicted about this, but thought returning the single "best" one was useful information

I think the weirder part of the current API is the "best" one isn't included in the complete vector


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93394/new/

https://reviews.llvm.org/D93394