[PATCH] D93394: CodeGen: Move function to get subregister indexes to cover a LaneMask

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 07:55:42 PST 2020


arsenm added a comment.

In D93394#2457781 <https://reviews.llvm.org/D93394#2457781>, @foad wrote:

> Seems like an obvious refactoring to me. I think the API could be simplified though. How about returning all indices via the SmallVector, and returning a bool failure indication? Or say that if the vector is empty, it means failure?

I was conflicted about this, but thought returning the single "best" one was useful information


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93394/new/

https://reviews.llvm.org/D93394



More information about the llvm-commits mailing list