[PATCH] D92200: Ensure SplitEdge to return the new block between the two given blocks

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki added a comment.

I have an auto-bisecting multi-stage cron job that has identified this change as the source of a testing regression during a release (with assertions disabled) build. Do you have a quick fix? Or should I revert this?

  FAIL: LLVM-Unit :: Transforms/Utils/./UtilsTests/BasicBlockUtils.splitBasicBlockBefore_ex2 (5026 of 72563)
  ******************** TEST 'LLVM-Unit :: Transforms/Utils/./UtilsTests/BasicBlockUtils.splitBasicBlockBefore_ex2' FAILED ********************
  Note: Google Test filter = BasicBlockUtils.splitBasicBlockBefore_ex2
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from BasicBlockUtils
  [ RUN      ] BasicBlockUtils.splitBasicBlockBefore_ex2
  /home/dave/ro_s/lp/llvm/unittests/Transforms/Utils/BasicBlockUtilsTest.cpp:286: Failure
  Death test: { DestBlock->splitBasicBlockBefore(DestBlock->front().getIterator(), "test"); }
      Result: failed to die.
   Error msg:
  [  DEATH   ]
  [  FAILED  ] BasicBlockUtils.splitBasicBlockBefore_ex2 (0 ms)
  [----------] 1 test from BasicBlockUtils (0 ms total)
  
  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (1 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] BasicBlockUtils.splitBasicBlockBefore_ex2
  
   1 FAILED TEST
  
  ********************
  ********************
  Failed Tests (1):
    LLVM-Unit :: Transforms/Utils/./UtilsTests/BasicBlockUtils.splitBasicBlockBefore_ex2
  
  
  Testing Time: 93.72s
    Unsupported      : 11228
    Passed           : 61234
    Expectedly Failed:   100
    Failed           :     1
  FAILED: CMakeFiles/check-all


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92200/new/

https://reviews.llvm.org/D92200