[PATCH] D92200: Ensure SplitEdge to return the new block between the two given blocks

Bangtian Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 00:06:14 PST 2020


kobeliu85 added inline comments.


================
Comment at: llvm/unittests/Transforms/Utils/BasicBlockUtilsTest.cpp:281
+
+  ASSERT_DEATH(
+      {
----------------
Meinersbur wrote:
> kaz7 wrote:
> > FYI, having failed to die error here.  I appreciate if you fix it.
> I think the crash would be due to an `assert`, which are removed in release builds. We cannot directly test assertions.
Thanks for the comment, I will investigate this today. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92200/new/

https://reviews.llvm.org/D92200



More information about the llvm-commits mailing list