[PATCH] D93010: [yaml2obj/obj2yaml] - Make Value/Size fields of Symbol optional.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-size.yaml:15-16
+  - Name:  aaa
+# CHECK:    Num: Value            Size Type    Bind   Vis       Ndx Name
+# CHECK:      1: 0000000000000000 0    NOTYPE  LOCAL  DEFAULT   UND aaa
+## The "Size" key is explicitly set to 0x0.
----------------
jhenderson wrote:
> Up to you, but here and below, you could probably reduce the amount of stuff needed by the test by using regex wildcards/numeric expressions to skip much of the check. For example, see the inline edit. The same technique could probably be used for each of the other cases too, in both tests.
Thanks for the suggestion! I've applied it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93010/new/

https://reviews.llvm.org/D93010