[PATCH] D93010: [yaml2obj/obj2yaml] - Make Value/Size fields of Symbol optional.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, with one possible set of suggestions.



================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-size.yaml:15-16
+  - Name:  aaa
+# CHECK:    Num: Value            Size Type    Bind   Vis       Ndx Name
+# CHECK:      1: 0000000000000000 0    NOTYPE  LOCAL  DEFAULT   UND aaa
+## The "Size" key is explicitly set to 0x0.
----------------
Up to you, but here and below, you could probably reduce the amount of stuff needed by the test by using regex wildcards/numeric expressions to skip much of the check. For example, see the inline edit. The same technique could probably be used for each of the other cases too, in both tests.


================
Comment at: llvm/test/tools/yaml2obj/ELF/symbol-value.yaml:15-16
+  - Name:  aaa
+# CHECK:    Num: Value            Size Type    Bind   Vis       Ndx Name
+# CHECK:      1: 0000000000000000 0    NOTYPE  LOCAL  DEFAULT   UND aaa
+## The "Value" key is explicitly set to 0x0.
----------------
Equivalent suggestion to above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93010/new/

https://reviews.llvm.org/D93010