[PATCH] D93340: Start Docker-izing sanitizer-windows

Wed Dec 16 01:58:07 PST 2020

kuhnel accepted this revision.
kuhnel added a comment.
This revision is now accepted and ready to land.

LGTM.

I'm not using the current deployment of the "windows10_vs2019" <https://github.com/llvm/llvm-zorg/blob/e95a9d734943a399a66cc9e0691138c44a82819a/buildbot/google/terraform/main.tf#L172> any more. So feel free to just modify that image and re-use the worker-config. That way you don't have to configure another deployment.

If you don't want to use that, I'll just delete to save resources.

================
Comment at: buildbot/google/docker/buildbot-sanitizer-windows/Dockerfile:2
+# escape=`
+FROM gcr.io/sanitizer-bots/windows-base-vscode2019:8
+
----------------
This base image still contains GnuWin, Python2 and an ancient version of the buildbot-worker.
So when starting with a new worker I guess we should clean that up (remove python2 and GnuWin, and upgrade to the latest builbot-worker)

Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93340/new/

https://reviews.llvm.org/D93340