[PATCH] D93340: Start Docker-izing sanitizer-windows

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 14:42:33 PST 2020


rnk created this revision.
rnk added reviewers: kuhnel, gkistanova, amccarth.
rnk requested review of this revision.

This defines a new docker image for sanitizer-windows based on the
existing docker image. I chose to dockerize sanitizer-windows first,
because it cycles quickly and doesn't do a two-stage build.

My plan is to have both the existing sanitizer-windows bot and the new
one run concurrently, but the new one will connect to the silent,
staging buildmaster (lab.llvm.org:9994). Once we are ready to cut over,
I will turn off the old sanitizer-windows VM and update this port in the
docker image and redeploy.

I am chosing to stick with the buildbot annotation script approach,
because it allows for much faster iteration: I can adjust paths for the
VS installation for example simply by committing to zorg. However, both
the live and staging bot will use the same script, so the same script
must work for both sanitizer-windows bots at the same time!


Repository:
  rZORG LLVM Github Zorg

https://reviews.llvm.org/D93340

Files:
  buildbot/google/docker/buildbot-sanitizer-windows/Dockerfile
  buildbot/google/docker/buildbot-sanitizer-windows/VERSION
  buildbot/google/docker/buildbot-sanitizer-windows/admin
  buildbot/google/docker/buildbot-sanitizer-windows/fix_buildbot_tac_paths.py
  buildbot/google/docker/buildbot-sanitizer-windows/run.ps1
  zorg/buildbot/builders/annotated/annotated_builder.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93340.312034.patch
Type: text/x-patch
Size: 6840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201215/1f6a1d8f/attachment.bin>


More information about the llvm-commits mailing list