[PATCH] D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns.

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 16 00:25:17 PST 2020


steven.zhang added a comment.

So, is this patch still incomplete as I didn't see the test change ?



================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1065
                     [(set i64:$rD,
-                          (aligned4sextloadi32 iaddrX4:$src))]>, isPPC64,
+                          (sextloadi32 dsfaddr:$src))]>, isPPC64,
                     PPC970_DGroup_Cracked;
----------------
Not sure if this is handled correctly as you are removing the align restrict for LWA. Technical speaking, we need to remove all such kind of alignment restrict in the load/store as far as we did some analysis in the source code. But I notice that we are removing the align restrict here but still keep it for LD. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93370/new/

https://reviews.llvm.org/D93370



More information about the llvm-commits mailing list