[PATCH] D93193: [RISCV] Define vsll/vsrl/vsra intrinsics.

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vsll.ll:11
+; CHECK-LABEL: intrinsic_vsll_vv_nxv1i8_nxv1i8_nxv1i8
+; CHECK:       vsetvli {{.*}}, {{a[0-9]+}}, e8,mf8,ta,mu
+; CHECK:       vsll.vv {{v[0-9]+}}, {{v[0-9]+}}, {{v[0-9]+}}
----------------
rogfer01 wrote:
> Related to @craig.topper comment at https://reviews.llvm.org/D93175#2452890 do we want the `,ta,mu` markers appear here?
> 
> I'd say so but maybe we have to to update earlier tests in the way?
I agree. We should have ",ta,mu" in vsetvli instructions. I think I missed the modification in some test cases. I will update them. Thanks for pointing it out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93193/new/

https://reviews.llvm.org/D93193