[PATCH] D93045: [ELF] AArch64: Handle DT_AARCH64_VARIANT_PCS

Mon Dec 14 10:56:17 PST 2020

MaskRay added a comment.

In D93045#2451478 <https://reviews.llvm.org/D93045#2451478>, @peter.smith wrote:

> In D93045#2449509 <https://reviews.llvm.org/D93045#2449509>, @zatrazz wrote:
>
>> Updated patch based on previous comments. For in.relaIplt / R_AARCH64_IRELATIVE
>> I decided to not include since it seems to what binutils is done currently. I will raise with
>> them if this is the intended behaviour or if R_AARCH64_IRELATIVE should also create
>> the dynamic tag (and fix is accordingly on lld if it were the case).
>
> As I understand it, IRELATIVE relocations are not resolved lazily by the dynamic loader so there would not need to be a variant PCS flag in this particular case. So I think it is likely binutils is right here. No harm in checking though.

Ah yes, IRELATIVE and (J[U]MP_SLOT referencing STT_GNU_IFUNC) relocations are eagerly resolved. Having a test will be good, too (which probably suggests to split the tests. You can leverage the newer utility `split-file %s %t`)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93045/new/

https://reviews.llvm.org/D93045